"Generate phase" fetching uids and gids according to the build context #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacostas
force-pushed
the
propagating-uids-gids
branch
2 times, most recently
from
1bc3cbe to
38f22db
Compare
mhdawson
reviewed
Oct 19, 2023
mhdawson
reviewed
Oct 19, 2023
pacostas
force-pushed
the
propagating-uids-gids
branch
4 times, most recently
from
f488259 to
4b2d60c
Compare
mhdawson
reviewed
Oct 24, 2023
generate.go
Outdated
| return DuringBuildPermissionsGetter{get_etc_passwd_file_content: epfg} | ||
| } | ||
|
|
||
| func Generate(dependencyManager DependencyManager, logger scribe.Emitter, duringBuildPermissionsGetter DuringBuildPermissionsGetter) packit.GenerateFunc { |
There was a problem hiding this comment.
I'm wondering if it would be simpler/cleaner to
- Just pass in the UID and GUID in a structure to Generate. The tests would just hard code those values when testing Generate
- Make the function to get the UID and GUID from the password file take a filename. We could then add tests which used a dummy password file(s) in the test directories to validate the functionality of reading extracting the UIDs and GUIDs
- Update main.go to simply call the function to get the UID and GUID with /etc/passwd and call Generate with the structure returned?
…t user permissions
pacostas
force-pushed
the
propagating-uids-gids
branch
from
4b2d60c to
dd38c12
Compare
mhdawson
reviewed
Oct 27, 2023
pacostas
force-pushed
the
propagating-uids-gids
branch
from
85c805e to
49110a4
Compare
thitch97
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge After
Summary
During the generate phase, we build the
buildand therunimage for the build phase and for the runtime. At the moment, the uid and gid of thebuildandrunimage are hardcoded inside the/bin/generateubi-nodejs-extension/generate.go
Lines 22 to 23 in 7caa04e
buildandrunimages, the uid and gid that thecnbuser has on the current context that the app is being built. This approach is preferable as it also matches the uid and gids we specify on this PR paketo-community/ubi-base-stack#22The implementation of this pr is as follows:
uidsandgidsinside thegeneratebinary, we fetch theuidandgidof the cnb user from theetc/passwdfile.Use Cases
Checklist